Skip to content

Conversation

@georgweiss
Copy link
Collaborator

@georgweiss georgweiss commented Jan 16, 2025

URLEncoder.encode() converts space char to +, which does not work if the string is a path variable.
Suggest to change the API for fetching attachments to use the (MongoDB) id instead of original file name, but this will require a change in the service.

All in all the native HttpClient is a bit of a challenge to work with... Or: the Jersey client makes a better job keeping the developer happy.

Also optimizes instantiation of LogEntryTable app to avoid multiple calls to create a OlogHttpClient.

See #3236

@shroffk
Copy link
Member

shroffk commented Jan 16, 2025

I expected the app.getClient() to always return the same instance if the client had been instantiated along the lines of a singleton pattern
This is more explicit though

@shroffk shroffk merged commit 111d6ce into master Jan 16, 2025
2 checks passed
@shroffk shroffk deleted the fix_http_client_timeout branch February 11, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants