backward compatibility for layout management see PR #3250 #3300
Conversation
backward compatibility see ControlSystemStudio#3250
| boolean statusBarVisible = PhoebusApplication.INSTANCE.isStatusbarVisible(); | ||
| MementoHelper.saveState(stagesToSave, memento_file, null, null,menuVisible, toolbarVisible, statusBarVisible); | ||
| if(memento_custom != null){ | ||
| MementoHelper.saveState(stagesToSave, memento_custom, null, null,menuVisible, toolbarVisible, statusBarVisible); |
There was a problem hiding this comment.
With this change, the layout is saved to both Locations.user() and layout_dir (if it has been set). Would it be possible to only save to Locations.user() by default (this is the old behavior), and to save to layout_dir only when the new functionality to do so has been enabled?
Probably, one wants to save only to one of the locations: layouts are loaded both from Locations.user() [1] and from layout_dir, and if one saves a layout to both, then the layout will appear twice in the Layouts menu.
There was a problem hiding this comment.
Hello, @abrahamwolk , ok I will see that. How the end users get the memento in a specific layout_dir before ?
Our End users , are not familiar with Phoebus and they even don't know where the default memento are stored.
Did you copy the file manually ?
What can I do, is adding a flag in preferences, by default, keep the old behavior , and if enable, save the layout in the custom layout_dir .
Do you think it's OK with this method ?
Thank you for your help.
Katy
There was a problem hiding this comment.
A use-case may be the following:
Locations.user()points to a writable user-specific directory, typically located in the user's home directory.layout_dirpoints to a global read-only directory that contains shared layouts.
Typically, users may modify their own user-specific layouts located in their home directory. Some specific layouts are shared between users, and they may be maintained and modified, e.g., in a shared repository. These shared layouts are then deployed to layout_dir (which is read-only, since the layouts in this directory are shared between several users).
What can I do, is adding a flag in preferences, by default, keep the old behavior , and if enable, save the layout in the custom layout_dir .
Do you think it's OK with this method ?
Yes, I think it's OK!
There was a problem hiding this comment.
OK I see. Thank you for your answer, I make the modification ASAP.
There was a problem hiding this comment.
Hello @abrahamwolk ,
Firstable, thank you for the "use-case" , it is interesting to use layout in this way for the operators control room.
According to the given use case, here are the modifications I propose :
- Layout files will be saved in layout_dir only if preference save_in_layout_dir is true and if Layout_dir exists and is writable
- By default save_in_layout_dir=false
- And all other case layout files are saved in user location.
I hope , it is OK , and it's work for your users .
Thank you for your review .
Katy
There was a problem hiding this comment.
Yes, this is OK. Thanks for fixing it!
save_layout_in_layout_dir is enable see PR ControlSystemStudio#3300
|
Thank you @abrahamwolk . I think it's OK if I merge so. Have a nice week end. |
2 participants
backward compatibility for layout management see comment in PR #3250