CSSTUDIO-3341 (1) Bugfix: fix zooming (2) Improve zooming: avoid hiding of OPI-elements behind scrollbars #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in the zoom-level being squared.
…n zooming using "WIDTH", "HEIGHT", or "ALL".
kasemir
approved these changes
Aug 5, 2025
georgweiss
reviewed
Aug 12, 2025
Collaborator
georgweiss
left a comment
georgweiss
left a comment
There was a problem hiding this comment.
I prefer Java code style (camel case) in new code...
georgweiss
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains one bugfix and one improvement:
widget_paneand that operations that were previously done through methods onwidget_parentwere changed to be done through methods onwidget_paneinstead, and therefore it seems plausible that the fix is "correct".WIDTH,HEIGHT, andALL, and fixes an issue where sometimes OPI UI-elements would be hidden behind scrollbars. With this improvement, they should no longer be hidden behind a scrollbar. I think the solution works well in general; please note, however, that in some corner cases, there may be a small gap between the edge of the zoomed-in OPI and the side of the window. The improvement is implemented in the commit 253f1a0.