Individual colors on navtabs #3680

gabriel-desmarchelier · 2025-12-19T13:13:28Z

This PR implements an option to allow each tab from the NavigationTabs widget to have its own colors.

Here is the use case that drives me to suggest this feature :
I want to be able to use rules to apply a specific color to a tab, depending on the status of the device associated to this tab.
Let's say I manage several power supply units and I want the tab color to show me which one is up, which one is ramping up, which one is in fault.

What it looks like when I'm looking into Tab0 but something happened in Tab2 :

Of course, I also want to know that I'm looking into Tab0, even when everything goes wrong :

So I implemented :

new tab properties as part of the Tab StructuredWidgetProperty
- individual_selected_color
- individual_deselected_color
new widget property : enable_individual_tab_colors
- if False : the usual selected_color and deselected_color are used
- if True : the new individual_selected_color and individual_deselected_color are used
- defaults to false, avoiding any breaking change

I also changed the name of tabs attribute and of setTabs method to clarify the fact that they refer to the tab names.

Here is a .bob with various configurations of NavigationTabs that use this feature :
nav_tabs_colors.tar.gz

Let me know if you think such a feature is relevant of if you think this not the right way to implement it.

Checklist

Testing:
- The feature has automated tests
- Tests were run
- If not, explain how you tested your changes
Documentation:
- The feature is documented
- The documentation is up to date
- Release notes:
  - Added an entry if the change is breaking or significant
  - Added an entry when adding a new feature

…dget accordingly

Copilot

Pull request overview

This PR implements individual tab color customization for the NavigationTabsWidget, allowing each tab to have its own selected and deselected colors. This feature enables visual status indication through tab colors (e.g., showing device status like "up", "ramping", or "fault" states).

Key Changes:

Added individual_selected_color and individual_deselected_color properties to each tab in the TabProperty structure
Introduced enable_per_tab_colors widget property to toggle between global and per-tab colors (defaults to false for backward compatibility)
Renamed setTabs() method to setTabNames() for better clarity about what the method does

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 23 comments.

File	Description
NavigationTabsWidget.java	Adds new color property descriptors and updates TabProperty structure with individual color fields; defines default color constants
NavigationTabsRepresentation.java	Updates listeners to handle new color properties; adds logic to collect and pass individual colors from model to UI component
NavigationTabs.java	Implements per-tab color rendering logic in updateTabs() and handleTabSelection(); adds fields for color lists and enable flag; renames tabs field to tab_names
NavigationTabsDemo.java	Updates demo to use renamed setTabNames() method instead of setTabs()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T15:05:57Z

...src/main/java/org/csstudio/display/builder/representation/javafx/widgets/NavigationTabs.java

-                pressed.setStyle("-fx-color: " + JFXUtil.webRGB(selected));
+                // If the per-tab colors are enabled, the color to apply is to be found in the tab_selected_colors list
+                if (enable_per_tab_colors == true) {
+                	if(i < tab_selected_colors.size()) {


Missing space after 'if' keyword. The code uses 'if(i' instead of 'if (i'. This is inconsistent with the Java code style used elsewhere in this file and should have a space after 'if'.

Copilot · 2026-01-06T15:05:57Z

...src/main/java/org/csstudio/display/builder/representation/javafx/widgets/NavigationTabs.java

+            	tmpColor = deselected;
+            	// If the per-tab colors are enabled, the color to apply is to be found in the tab_deselected_colors list
+                if (enable_per_tab_colors == true) {
+                	if(i < tab_deselected_colors.size()) {


Missing space after 'if' keyword. The code uses 'if(i' instead of 'if (i'. This is inconsistent with the Java code style used elsewhere in this file and should have a space after 'if'.

Suggested change

if(i < tab_deselected_colors.size()) {

if (i < tab_deselected_colors.size()) {

Copilot · 2026-01-06T15:05:57Z

...org/csstudio/display/builder/representation/javafx/widgets/NavigationTabsRepresentation.java

+            final List<WidgetColor> tab_selected_colors  = new ArrayList<>();
+            final List<WidgetColor> tab_deselected_colors  = new ArrayList<>();


Extra whitespace before the closing semicolon. Line 400 has two spaces after 'tab_selected_colors' and line 401 has two spaces after 'tab_deselected_colors'. This should be a single space for consistency.

Suggested change

final List<WidgetColor> tab_selected_colors = new ArrayList<>();

final List<WidgetColor> tab_deselected_colors = new ArrayList<>();

final List<WidgetColor> tab_selected_colors = new ArrayList<>();

final List<WidgetColor> tab_deselected_colors = new ArrayList<>();

Copilot · 2026-01-06T15:05:58Z

...src/main/java/org/csstudio/display/builder/representation/javafx/widgets/NavigationTabs.java

+				// Set color to global "selected" color value
+				tmpColor = selected;
+				// If the per-tab colors are enabled, the color to apply is to be found in the tab_selected_colors list
+				if (enable_per_tab_colors == true) {


Avoid explicit boolean comparisons like 'enable_per_tab_colors == true'. Since enable_per_tab_colors is already a boolean, this should be simplified to just 'enable_per_tab_colors' for better readability and consistency with Java best practices.

Copilot · 2026-01-06T15:05:58Z

...src/main/java/org/csstudio/display/builder/representation/javafx/widgets/NavigationTabs.java

                // Highlight active tab by setting it to the 'selected' color
-                pressed.setStyle("-fx-color: " + JFXUtil.webRGB(selected));
+                // If the per-tab colors are enabled, the color to apply is to be found in the tab_selected_colors list
+                if (enable_per_tab_colors == true) {


Avoid explicit boolean comparisons like 'enable_per_tab_colors == true'. Since enable_per_tab_colors is already a boolean, this should be simplified to just 'enable_per_tab_colors' for better readability and consistency with Java best practices.

Copilot · 2026-01-06T15:06:02Z

...org/csstudio/display/builder/representation/javafx/widgets/NavigationTabsRepresentation.java

+            final List<String> tab_names = new ArrayList<>();
+            final List<WidgetColor> tab_selected_colors  = new ArrayList<>();
+            final List<WidgetColor> tab_deselected_colors  = new ArrayList<>();
+


Trailing whitespace at the end of line 402. This should be removed.

Suggested change

Copilot · 2026-01-06T15:06:02Z

...src/main/java/org/csstudio/display/builder/representation/javafx/widgets/NavigationTabs.java

+				// Set color to global "deselected" color value
+            	tmpColor = deselected;
+            	// If the per-tab colors are enabled, the color to apply is to be found in the tab_deselected_colors list
+				if (enable_per_tab_colors == true) {


Avoid explicit boolean comparisons like 'enable_per_tab_colors == true'. Since enable_per_tab_colors is already a boolean, this should be simplified to just 'enable_per_tab_colors' for better readability and consistency with Java best practices.

Copilot · 2026-01-06T15:06:03Z

...org/csstudio/display/builder/representation/javafx/widgets/NavigationTabsRepresentation.java

+            jfx_node.setTabNames(tab_names);
+            jfx_node.setTabSelectedColors(tab_selected_colors);
+            jfx_node.setTabDeselectedColors(tab_deselected_colors);


Calling setTabNames(), setTabSelectedColors(), and setTabDeselectedColors() sequentially causes updateTabs() to be called three times, recreating all tab buttons unnecessarily on each call. Consider creating a single method that accepts all three lists to avoid redundant updates, or consider batching these updates more efficiently.

Copilot · 2026-01-06T15:06:03Z

...src/main/java/org/csstudio/display/builder/representation/javafx/widgets/NavigationTabs.java

+            	// Set color to global "deselected" color value
+            	tmpColor = deselected;
+            	// If the per-tab colors are enabled, the color to apply is to be found in the tab_deselected_colors list
+                if (enable_per_tab_colors == true) {
+                	if(i < tab_deselected_colors.size()) {
+                		tmpWidgetColor = tab_deselected_colors.get(i);
+                		tmpColor = JFXUtil.convert(tmpWidgetColor);
+                	}
+                }
+                button.setStyle("-fx-color: " + JFXUtil.webRGB(tmpColor));


Inconsistent indentation: these lines use tabs mixed with spaces while the rest of the file uses spaces consistently. Java code should consistently use spaces for indentation (typically 4 spaces per level) to match the existing code style.

Copilot · 2026-01-06T15:06:03Z

...src/main/java/org/csstudio/display/builder/representation/javafx/widgets/NavigationTabs.java

-        {
-            final ToggleButton button = new ToggleButton(tabs.get(i));
+        Color tmpColor = deselected;
+        WidgetColor tmpWidgetColor = null;


The variable tmpWidgetColor is declared but never used in a meaningful way. It's assigned values but those values are never read. This variable should be removed and you can directly pass the list element to JFXUtil.convert().

Gabriel Desmarchelier added 3 commits December 19, 2025 11:15

create individual color properties for each tab

251ed4a

create enable_individual_colors propert for navtabs and manage the wi…

c0bef37

…dget accordingly

fix call to setTabNames in NavigationTabsDemo.java

e96f8d6

shroffk requested review from Copilot and georgweiss and removed request for georgweiss January 6, 2026 14:54

Copilot started reviewing on behalf of shroffk January 6, 2026 14:54 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Individual colors on navtabs #3680

Individual colors on navtabs #3680

Uh oh!

gabriel-desmarchelier commented Dec 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	if(i < tab_deselected_colors.size()) {
	if (i < tab_deselected_colors.size()) {

		final List<WidgetColor> tab_selected_colors = new ArrayList<>();
		final List<WidgetColor> tab_deselected_colors = new ArrayList<>();

Individual colors on navtabs #3680

Are you sure you want to change the base?

Individual colors on navtabs #3680

Uh oh!

Conversation

gabriel-desmarchelier commented Dec 19, 2025

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant