Skip to content

Conversation

@AnushK-Fro
Copy link
Contributor

@AnushK-Fro AnushK-Fro commented Nov 10, 2024

Guest Agent

Changes

  1. Added support for using the QEMU Guest Agent to set passwords on Windows Server installations.
  2. Enabled instant password resets through the Guest Agent, which avoids the need for reboots. Unlike Cloudinit (which requires a reboot to set passwords on Linux), the Guest Agent can update passwords immediately. This also solves the issue of Cloudinit not supporting Windows Server on Proxmox.

Issues

  • The server will be turned on regardless of whether the user checks or unchecks the start on completion function. Having a checkbox to start on completion is probably not required.

IPAM

This change increases the pagination limit for IP addresses. The IPAM is typically slow when trying to assign an IP address to a VM on a node that has more than 100 available IP addresses, since the current approach only provides 100 results each time a user enters a value. There is no need to paginate the IPAM since the amount of data is small. Loading all of the IP addresses at once dramatically speeds up the process of selecting an IP address and makes it less frustrating for the user.

@AnushK-Fro AnushK-Fro changed the title Add support for QEMU Guest Agent Add support for QEMU Guest Agent and Fix Issue with IPAM Nov 10, 2024
@ericwang401
Copy link
Collaborator

The tests need to pass btw

@AnushK-Fro
Copy link
Contributor Author

Should be fixed now

@AnushK-Fro AnushK-Fro mentioned this pull request Nov 27, 2024
1 task
@ericwang401 ericwang401 self-requested a review December 31, 2024 18:10
Copy link
Collaborator

@ericwang401 ericwang401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this code. Something about it seems off, maybe because I didn't create it. Oh well, I'm planning on incorporating my own solution in v10

Copy link
Collaborator

@ericwang401 ericwang401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helloooo

@ericwang401 ericwang401 merged commit bc9aada into ConvoyPanel:develop Jan 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants