Skip to content

Fix issue #123 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericwang401 merged 4 commits into from
Jan 1, 2025
Merged

Fix issue #123 #124

ericwang401 merged 4 commits into from
Jan 1, 2025

Conversation

@Adekabang
Copy link
Contributor

@Adekabang Adekabang commented Nov 27, 2024 •
edited
Loading

fix issue unauthenticated user access route with dynamic params:

  • /admin/user/{id}/*
  • /admin/nodes/{nodeid}/*
  • /admin/ipam/{id}/*

@Adekabang Adekabang mentioned this pull request Nov 27, 2024
Closed
2 tasks
@ericwang401 ericwang401 self-requested a review January 1, 2025 05:05
ericwang401
ericwang401 approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@ericwang401 ericwang401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ericwang401 ericwang401 merged commit c5ff6f7 into ConvoyPanel:develop Jan 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericwang401 ericwang401 ericwang401 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Adekabang @ericwang401