MSVC assembly fixups/cleanups#113
Merged
CookiePLMonster merged 5 commits intoCookiePLMonster:devfrom Nov 18, 2024
Merged
Conversation
CookiePLMonster
requested changes
Nov 13, 2024
Some of them use the deference operator incorrectly (also clean them up in general)
Also clean them up in general
Also clean them up in general
Also clean them up in general
Also clean them up in general
TheComputerGuy96
force-pushed
the
fix-msvc-asm
branch
from
f1a9ca8 to
fdce60d
Compare
Owner
|
Looks good overall, I'll give it a spin next time I am working on SP. |
CookiePLMonster
approved these changes
Nov 18, 2024
Owner
CookiePLMonster
left a comment
CookiePLMonster
left a comment
There was a problem hiding this comment.
Tested all 3 games, looks all good now. Is this fine to squash into a single commit?
Contributor
Author
|
@CookiePLMonster The SA part should probably be left unsquashed (because it's relatively big) |
Owner
|
OK, I see the review fix was force pushed, so even unsquashed history is clean. Fine by me then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a separate MR based on a suggestion in #95 (comment)