-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Implement native CORE token burn functionality #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ysv
merged 3 commits into
CoreumFoundation:master
from
ShieldnestORG:feature/native-burn-function
Dec 19, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -315,14 +315,19 @@ func CmdTxBurn() *cobra.Command { | |
| cmd := &cobra.Command{ | ||
| Use: "burn [amount] --from [sender]", | ||
| Args: cobra.ExactArgs(1), | ||
| Short: "burn some amount of fungible token", | ||
| Short: "burn some amount of fungible token or governance denom", | ||
| Long: strings.TrimSpace( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add aditional test to tx_test.go in this folder. |
||
| fmt.Sprintf(`Burn some amount of fungible token. | ||
| fmt.Sprintf(`Burn some amount of fungible token or the governance/bond denom (core/testcore/devcore). | ||
|
|
||
| Example: | ||
| $ %s tx %s burn 100000ABC-%s --from [sender] | ||
| For AssetFT tokens, the token must have the burning feature enabled. | ||
| For the governance denom, no token definition is required. | ||
|
|
||
| Examples: | ||
| $ %s tx %s burn 100000ABC-%s --from [sender] # Burn AssetFT token | ||
| $ %s tx %s burn 50000udevcore --from [sender] # Burn governance denom | ||
| `, | ||
| version.AppName, types.ModuleName, constant.AddressSampleTest, | ||
| version.AppName, types.ModuleName, | ||
| ), | ||
| ), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing since there is supply increase in every block due to inflation. you can run integration tests via
make integration-tests-modules.to get around the issue, you can increase the burn amount to much larger value(1 million core or 10^12 ucore) to overshadow the minted value by minting module and instead of doing exact match assert that actual supply decrease is within 0.0001 of the expected decrease (you can utilize require.InEplison for assertion).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i pushed the fixes. Forgot to retest after fix. Pushed updates your way!