Accessing database stats with explicit transaction #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding method to `LightningTransaction` to load database stats. This is useful when the database was opened via a committed transaction, and then subsequently re-used by later transactions (since the original transaction is no longer valid). Also updating LightningDatabase.DatabaseStats to call this method with its original transaction to reduce duplicate code.
|
Thanks again, I will try and follow-up with a release this next weekend. It's unfortunately a very busy time of year for me work-wise. |
|
Nuget package 0.17.1 has been published with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding method to
LightningTransactionto load database stats. This is useful when the database was opened via a committed transaction, and then subsequently re-used by later transactions (since the original transaction is no longer valid).Also updating
LightningDatabase.DatabaseStatsto call this method with its original transaction to reduce (now) duplicate code.Added test cases for new method and
LightningDatabase.DatabaseStats.