Skip to content

fix: limit max_results in search API to prevent DoS #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echobt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: limit max_results in search API to prevent DoS #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/server/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,10 @@ async fn search(
}
};

let candidates = match db.search_similar(&query_embedding, &abs_path, req.max_results * 3) {
// Limit max_results to prevent DoS/OOM
let max_results = req.max_results.min(1000);

let candidates = match db.search_similar(&query_embedding, &abs_path, max_results * 3) {
Ok(c) => c,
Err(e) => {
return (
Expand Down Expand Up @@ -287,7 +290,7 @@ async fn search(
.unwrap_or(std::cmp::Ordering::Equal)
});

results.truncate(req.max_results);
results.truncate(max_results);

let total = results.len();

Expand Down
Loading