Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency version constraints for gensim and scipy, while also bumping the project version and expanding Python version support to include Python 3.13.
Key Changes:
- Updated
scipyfrom<1.13to~=1.13andgensimfrom>=4.3.2to~=4.4.0 - Expanded Python version support to include 3.13 (changed from
<3.13to<3.14) - Bumped project version from 0.7.2 to 0.7.3
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
josenimo
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| dependencies = [ | ||
| "spatialdata == 0.4.0", | ||
| "numpy >= 2.0.0", | ||
| "spatialdata >= 0.4.0", |
There was a problem hiding this comment.
The dependency constraint for spatialdata was changed from exact version (==) to minimum version (>=), which may introduce breaking changes. Since the previous version was pinned to 0.4.0, consider using a pessimistic constraint like ~= 0.4.0 to allow patch updates while preventing breaking minor version changes.
| "spatialdata >= 0.4.0", | |
| "spatialdata ~= 0.4.0", |
| "scanpy >=1.11, <1.14", | ||
| "loguru ~= 0.7.3", | ||
| "scipy <1.13", # Gensim breaks above | ||
| "scipy ~= 1.13", |
There was a problem hiding this comment.
The constraint changed from <1.13 to ~= 1.13, which now requires scipy version 1.13 or higher (but <2.0). The comment 'Gensim breaks above' was removed, but this constraint may still cause issues if gensim is incompatible with scipy 1.13+. Verify that gensim 4.4.0 is compatible with scipy 1.13+.
| "scipy ~= 1.13", | |
| "scipy <1.13", # Gensim breaks above 1.13 |
| "upsetplot", | ||
| "perseuspy >=0.3.9,<0.4", | ||
| "gensim >=4.3.2", # Gensim breaks with python >=3.13 | ||
| "gensim ~=4.4.0", |
There was a problem hiding this comment.
The gensim version was updated from >=4.3.2 to ~=4.4.0, and the comment 'Gensim breaks with python >=3.13' was removed. Verify that gensim 4.4.0 actually supports Python 3.13, as the comment removal suggests this was a blocker for Python 3.13 support.
No description provided.