Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Babylon’s dependency set and workflow tooling while extending the workspace lifecycle to manage additional Kubernetes resources (workspace Secret + CoAL ConfigMap) and improving troubleshooting output when Kubernetes secrets are missing.
Changes:
- Bump Python dependencies (incl.
cosmotech-api,ruff, Azure SDKs) and refreshuv.lock. - Add Kubernetes Secret/ConfigMap creation during workspace deploy and deletion during destroy.
- Rename webapp URL inputs from
cluster_domaintocluster_name + domain_zone, update templates, and bumpazure/loginaction to v3.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Refresh locked dependency versions and transitive set (incl. docs tooling deps). |
pyproject.toml |
Bump cosmotech-api to 5.0.1 and ruff minimum to 0.15.7. |
Babylon/version.py |
Bump Babylon version string to 5.1.0. |
Babylon/utils/environment.py |
Add richer troubleshooting output (active kubectl context + Babylon namespace info) when a secret is missing. |
Babylon/templates/working_dir/.templates/yaml/variables.yaml |
Replace cluster_domain with domain_zone variable. |
Babylon/templates/working_dir/.templates/yaml/Webapp.yaml |
Update payload field from cluster_domain to domain_zone. |
Babylon/commands/macro/deploy.py |
Add helpers to create/delete workspace Secret and CoAL ConfigMap; update webapp URL computation to use domain_zone. |
Babylon/commands/macro/deploy_workspace.py |
Call new deploy helpers after schema init. |
Babylon/commands/macro/destroy.py |
Delete the newly created Kubernetes resources during destroy. |
.github/workflows/ci.yml |
Update azure/login from v2 to v3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sellisd
approved these changes
Mar 25, 2026
|
|
||
| from Babylon.commands.api.workspace import get_workspace_api_instance | ||
| from Babylon.commands.macro.deploy import get_postgres_service_host, update_object_security | ||
| from Babylon.commands.macro.deploy import ( |
Contributor
There was a problem hiding this comment.
The macro command for creating a workspace is very different from the micro-command that just reflects the API, I wonder if it is worth adding some comment in the source to make this clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.