Pin LocalStack image version to 4.14.0 in test configurations#1159
Merged
jreynard-code merged 2 commits intomainfrom Mar 26, 2026
Merged
Pin LocalStack image version to 4.14.0 in test configurations#1159jreynard-code merged 2 commits intomainfrom
jreynard-code merged 2 commits intomainfrom
Conversation
sjoubert
requested changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
- Would it make sense to merge the 2 TestBase into a single one in the common folder? They seem very similar but also have slight differences. For example the common one does not handle the localstack in
beforeAlland both localstack and redis are missing fromafterAll. But maybe the difference is intended and the reason for having 2 files - In any case, should
CsmTestBasebe in the common/src/test folder instead of main/ ?
…th `CsmTestBase` and add `@EnableRedisDocumentRepositories` annotations
sjoubert
approved these changes
Mar 26, 2026
jreynard-code
deleted the
fix_localstack_version_until_alternative_usage
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.