Skip to content

feat: migrate automation client from old modules#5

Open
sellisd wants to merge 1 commit intomainfrom
DSE/automation_client
Open

feat: migrate automation client from old modules#5
sellisd wants to merge 1 commit intomainfrom
DSE/automation_client

Conversation

@sellisd
Copy link
Copy Markdown

@sellisd sellisd commented Mar 4, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Terraform submodule under modules/cicd to provision a Keycloak OpenID “automation-client” (plus protocol mapper and service-account realm role), along with local docker-compose + terraform test scaffolding to validate creation against a local Keycloak instance.

Changes:

  • Introduces modules/cicd Terraform code to create the Keycloak automation client and related resources.
  • Adds terraform test setup plus a docker-compose Keycloak instance and imported test realm.
  • Adds module README and required input variables (tenant, api_dns_name).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
modules/cicd/main.tf Creates Keycloak realm lookup + automation client + mapper + service-account role assignment
modules/cicd/variables.tf Declares module inputs (tenant, api_dns_name)
modules/cicd/README.md Documents module purpose and local testing steps
modules/cicd/tests/keycloak.tftest.hcl Terraform test asserting automation client creation
modules/cicd/tests/docker-compose.yml Local Keycloak container for tests
modules/cicd/tests/config/tenant-test-realm.json Imported realm/role fixture for tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread modules/cicd/main.tf
Comment thread modules/cicd/tests/keycloak.tftest.hcl
Comment thread modules/cicd/main.tf
Comment thread modules/cicd/main.tf
Comment thread modules/cicd/tests/docker-compose.yml Outdated
Comment thread modules/cicd/variables.tf Outdated
Comment thread modules/cicd/main.tf
@ggtrd ggtrd self-assigned this Mar 4, 2026
@sellisd sellisd marked this pull request as draft March 4, 2026 12:58
@sellisd sellisd requested a review from Copilot March 5, 2026 10:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread modules/cicd/tests/keycloak.local.tfvars
Comment thread modules/cicd/variables.tf
Comment thread modules/cicd/main.tf
Comment thread modules/cicd/main.tf Outdated
Comment thread modules/cicd/tests/keycloak.tftest.hcl
Comment thread modules/cicd/README.md
Comment thread modules/cicd/main.tf
Comment thread modules/cicd/main.tf
@sellisd sellisd force-pushed the DSE/automation_client branch from 9323ea3 to 7fcd791 Compare March 5, 2026 11:10
@sellisd sellisd force-pushed the DSE/automation_client branch from 7fcd791 to 7204114 Compare March 27, 2026 15:51
@sellisd sellisd marked this pull request as ready for review March 27, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants