feat!: [PROD-14533] handle dataset bases permissions in scenario shar…#439
Merged
nborde-CSM merged 2 commits intomainfrom Nov 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for handling dataset base permissions in the scenario sharing role edition dialog. The changes allow the UI to display which users cannot be granted access because they lack read permissions to certain dataset bases.
Key changes:
- Modified the
agentsprop structure from a simple array to an array of objects containing user IDs and dataset restrictions - Added visual feedback (tooltips and disabled state) for users who cannot be granted access due to dataset permission issues
- Updated PropTypes definitions to reflect the new data structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| RolesEditionDialog.js | Enhanced Autocomplete component to display disabled states and tooltips for users who cannot read certain datasets; updated PropTypes to reflect new agent structure |
| RolesEditionButton.js | Updated PropTypes documentation and definition for the new agents prop structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nborde-CSM
force-pushed
the
NBO/adapat_scenario_sharing_to_API_V5_PROD-14533
branch
from
e05b65a to
6faa0ee
Compare
nborde-CSM
force-pushed
the
NBO/adapat_scenario_sharing_to_API_V5_PROD-14533
branch
from
6faa0ee to
de9f8ec
Compare
nborde-CSM
force-pushed
the
NBO/adapat_scenario_sharing_to_API_V5_PROD-14533
branch
6 times, most recently
from
96f1cc0 to
2edd8fb
Compare
nborde-CSM
force-pushed
the
NBO/adapat_scenario_sharing_to_API_V5_PROD-14533
branch
2 times, most recently
from
64cb7a4 to
dc38880
Compare
csm-thu
approved these changes
Nov 21, 2025
Member
csm-thu
left a comment
csm-thu
left a comment
There was a problem hiding this comment.
Some questions and suggestions, but LGTM 👍
nborde-CSM
force-pushed
the
NBO/adapat_scenario_sharing_to_API_V5_PROD-14533
branch
from
dc38880 to
0a65087
Compare
…ing role edition dialog
BEARKING CHANGES:
In Role Edition Dialog, isReadOnly prop has been removed and has been replaced by
two new props:
- hasWriteSecurityPermission (boolean and optional)
- specificSharingRestriction (functon and optional)
nborde-CSM
force-pushed
the
NBO/adapat_scenario_sharing_to_API_V5_PROD-14533
branch
from
0a65087 to
9754dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing role edition dialog
BREAKING CHANGE : The "agent" prop of RoleEdtionButton and RoleEditionDialog is now an
array of objects