Skip to content

fix: [PROD-12777] prevent adding duplicate tags in TagsEditor component #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edonzeqiri95 merged 1 commit into from
Nov 20, 2025
Merged

fix: [PROD-12777] prevent adding duplicate tags in TagsEditor component #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/inputs/TagsEditor/TagsEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ export const TagsEditor = (props) => {
const addNewTag = useCallback(
(newTag) => {
setIsEditing(false);
if (newTag.trim().length === 0) return;
onChange([...values, newTag]);
const trimmedTag = newTag.trim();
if (trimmedTag.length === 0) return;

const tagAlreadyExists = values.some((existingTag) => existingTag === trimmedTag);
if (tagAlreadyExists) return;

onChange([...values, trimmedTag]);
},
[onChange, values]
);
Expand Down
36 changes: 36 additions & 0 deletions src/inputs/TagsEditor/TagsEditor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,5 +135,41 @@ describe('TagsEditor', () => {
expect(onChangeMockFunction).not.toHaveBeenCalled();
expect(newTagTextField.TextField).not.toBeInTheDocument();
});

test('should not add duplicate tags', async () => {
await tagsEditorContainer.hover();
expect(queryByTestId(document, 'EditIcon')).toBeVisible();

await userEvent.click(queryByTestId(document, 'EditIcon'));
expect(newTagTextField.TextField).toBeVisible();

await newTagTextField.type('tag1{enter}');
expect(onChangeMockFunction).not.toHaveBeenCalled();
expect(newTagTextField.TextField).not.toBeInTheDocument();
});

test('should not add duplicate tags even with whitespace', async () => {
await tagsEditorContainer.hover();
expect(queryByTestId(document, 'EditIcon')).toBeVisible();

await userEvent.click(queryByTestId(document, 'EditIcon'));
expect(newTagTextField.TextField).toBeVisible();

await newTagTextField.type(' tag2 {enter}');
expect(onChangeMockFunction).not.toHaveBeenCalled();
expect(newTagTextField.TextField).not.toBeInTheDocument();
});

test('should trim whitespace when adding new tags', async () => {
await tagsEditorContainer.hover();
expect(queryByTestId(document, 'EditIcon')).toBeVisible();

await userEvent.click(queryByTestId(document, 'EditIcon'));
expect(newTagTextField.TextField).toBeVisible();

await newTagTextField.type(' newtag {enter}');
expect(onChangeMockFunction).toHaveBeenCalledWith(['tag1', 'tag2', 'tag3', 'newtag']);
expect(newTagTextField.TextField).not.toBeInTheDocument();
});
});
});