Conversation
| import { far } from "@fortawesome/free-regular-svg-icons"; | ||
| import { BASE_URL } from "./services/constants"; | ||
| import { handleSignup, handleLogin, handleLogout } from "./services/User"; | ||
| import GroupPage from "./components/GroupPage/GroupPage" |
There was a problem hiding this comment.
Are you using this page somewhere? Should there be a route for it?
| .wrapper { | ||
| text-align: center; | ||
| } | ||
|
|
||
| h1{ | ||
| display: inline-block; | ||
| } |
There was a problem hiding this comment.
Can you update the CSS here so it's inline with the conventions in the README?
| @@ -0,0 +1,47 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Why is this page in the components directory and not the pages directory?
| <GroupCard | ||
| name="DIY with your kids" | ||
| members="98" | ||
| location="Boston, MA" | ||
| picture={card1} | ||
| /> |
There was a problem hiding this comment.
Should these be coming from the API?
| componentDidMount() { | ||
| axios.get(`${BASE_URL}/groups`) | ||
| .then(response => { | ||
| this.setState({ | ||
| groups: response.data | ||
| }) | ||
| }) | ||
| .catch(error => { | ||
| console.log('Error while fetching and parsing API request', error); | ||
| }) | ||
| } |
There was a problem hiding this comment.
Can you put this in the appropriate service in the services/ directory? All AJAX requests should be in a service
| } | ||
|
|
||
| render() { | ||
| console.log(this.state) |
There was a problem hiding this comment.
Be sure to delete all commented out code and any console.log or print statements before making a PR going forward
| members="5" | ||
| location="Chicago, IL" | ||
| picture={picture2} | ||
| <div className="CommunityPage__group-location-container"> |
There was a problem hiding this comment.
We decided to remove this Pill section right?
| <Card outline size="medium-wide-directory"> | ||
| <a href="/">Discover New Groups</a> | ||
| </Card>{" "} | ||
| <a className="seeMore-Button">See More</a> |
There was a problem hiding this comment.
Can you use names inline with the naming convention described in the README?
| </div> | ||
| <div className="CommunityPage__groups-in-city-container"> | ||
| {groups.map(group =>{ | ||
| console.log(group) |
|
The updates from this branch have been incorporated into #654 . This branch can be closed without merging. |
3 participants
Related Issue (include '#'): As a user I would like see what groups I am in #441
Description of changes made:
Is the feature complete/bug resolved/etc..:
Any known bugs/strange behavior:
Is there specific feedback you would like on these changes:
Screenshot(s):