Improve URI option decomposition to better match CoAP RFC 7252#116
Merged
Covertness merged 2 commits intoCovertness:masterfrom Jun 15, 2025
Merged
Improve URI option decomposition to better match CoAP RFC 7252#116Covertness merged 2 commits intoCovertness:masterfrom
Covertness merged 2 commits intoCovertness:masterfrom
Conversation
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the URI decomposition logic to better conform to the CoAP specification (section 6.4), addressing the following points:
Uri-Host (Point 5)
The implementation now omits the
Uri-Hostoption when the<host>component is an IP address.Uri-Query (Point 9)
Query arguments are now correctly split and included as separate
Uri-Queryoptions. The API forRequestBuilderis modified to support this change.