feat(multisig): add timelock mechanism and TransactionData struct with NatSpec documentation#70
Merged
2PykeETH merged 3 commits intoCraftMeme:mainfrom Sep 30, 2025
Merged
Conversation
2PykeETH
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances
MultiSigContractV2with a timelock mechanism for critical operations and introduces a structured representation of transaction metadata via the newTransactionDatastruct. These additions improve contract security, governance transparency, and maintainability.Changes
Timelock Mechanism
uint256 public timelockDelay = TIMELOCK_DURATION;New Struct:
TransactionDatatxId: Unique transaction identifier.owner: Initiator of the transaction.signers: Set of eligible signers.signatures: Collected approvals.requiredSignatures: Threshold for execution.createdAt: Timestamp when the transaction was created.expiresAt: Timestamp for expiration.executedAt: Timestamp for successful execution.executed: Boolean flag for execution status.cancelled: Boolean flag for cancellation status.description: Human-readable description of the transaction.data: Encoded calldata for execution.timelockEnd: Enforces minimum waiting period before execution.Formatting
forge fmtfor style consistency.Codebase Metrics
Why This Change
TransactionData) to support advanced governance features such as auditing, expiration, cancellation, and historical queries.Impact
Testing
TransactionData.Next Steps
TransactionData.