Correct placement of replicaCount settings in site customizations tem… #2374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Can I get a review of this mod please. It's pretty trivial - but it will hopefully avoid confusion on the customer's part in future. |
Zakaria-Baani
approved these changes
Jun 26, 2023
Contributor
|
@andrewpbarry is this PR still relevant? It's 2 years old, but looking at the current
It should probably also be re-targeted to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
fix a bug in the customizations.yaml template in which the rsyslog-aggregator and rsyslog-aggregator-udp sections include a replicaCount setting, which should be an argument to the the cray-services template, but is not. As written changing this value does not change the number of pods, as intended. Moving it to a argument value of cray-services corrects the problem. The default setting of 3 pods works well for modestly sized systems, but for large customer systems with thousands of compute nodes, having a way to increase the number of pods is required.
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
CSM-1.4- Not clear how badly the customer needs this fixed in the template, and can just update the site-local copy.Testing
Tested on:
Tested initially on Alvarez (Nersc TDS system), then on rocket.
Test description:
Set the corrected syntax in the customizations.yaml file, then ran the SMA installer, observing that the number of pods had been updated to the intended value.
Risks and Mitigations
No known risks.
Pull Request Checklist