Skip to content

Hotfix RSPEC tests upon ActiveRecord gem update #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arielr-lt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hotfix RSPEC tests upon ActiveRecord gem update #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d17d47f
Implement not-found error handling in API base class
arielr-lt Oct 31, 2025
0ba2541
Simplify error message for organization not found
arielr-lt Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/api/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@

module API
# Main base class that defines all API versions
class Base < Grape::API
class Base < Grape::API
# Normalize ActiveRecord not-found errors to a stable API message
rescue_from ActiveRecord::RecordNotFound do |e|
model = e.respond_to?(:model) && e.model ? e.model : 'Resource'
error!({ errors: ["#{model} not found"] }, 404)
end
insert_after Grape::Middleware::Formatter, Grape::Middleware::Logger, {
logger: MR.logger,
filter: Class.new do
Expand Down
5 changes: 1 addition & 4 deletions spec/api/v1/publish_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,10 +706,7 @@
it 'returns 404' do
transfer_ownership
expect_status(:not_found)
expect_json(
'errors.0',
"Couldn't find Organization with 'id'=#{new_organization_id}"
)
expect_json('errors.0', 'Organization not found')
end
end

Expand Down
Loading