feat: add internal user type management functions to IdentityManagerV2#60
Merged
SynnekOG merged 4 commits intoCrediChain:mainfrom Sep 25, 2025
Merged
feat: add internal user type management functions to IdentityManagerV2#60SynnekOG merged 4 commits intoCrediChain:mainfrom
SynnekOG merged 4 commits intoCrediChain:mainfrom
Conversation
SynnekOG
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces two new internal utility functions to
IdentityManagerV2that handle user tracking by type. These functions improve how the contract manages categorized users, ensuring consistent updates to internal mappings and arrays.Changes
Added
_addToUsersByTypeUserTypeusersByTypearrayAdded
_removeFromUsersByTypeUserTypelist while maintaining array compactnessuserPositionsmapping for O(1) lookupsNatspec comments for both functions for improved readability and documentation.
Benefits
Next Steps
_addToUsersByTypeand_removeFromUsersByTypeinto the verification and de-verification flowsNotes
These changes set the foundation for scalable identity management, where users may be grouped by type for permissions, analytics, or governance logic.