Fix undefined function calls in _crosstl.py from PR #290 #293
+1
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove incomplete modern translation engine code that references undefined functions: reset_errors(), get_translation_engine(), and get_error_collector(). Keep the working legacy translation system. Co-authored-by: NripeshN <86844847+NripeshN@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues in pull request 290
Fix undefined function calls in _crosstl.py from PR #290
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #290 introduced
NameErrorby calling three undefined functions (reset_errors(),get_translation_engine(),get_error_collector()) in the translation path. This breaks all translation operations.Changes
Removed incomplete modern translation engine fallback (24 lines in
_crosstl.py)reset_errors(),get_translation_engine(), andget_error_collector()Preserved all PR Remove Redundancy with base infrastructure #290 improvements
crosstl/utils/type_mappings.pycrosstl/utils/ast_utils.pyImpact
Translation now works without runtime errors:
All backend type mappings (
cuda,metal,directx, etc.) remain functional.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.