Open
Conversation
Contributor
Author
|
The target version has been changed to v17. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
I tried writing a patch like the one below, but applying it failed. I think it's difficult to merge these patches, because the type of |
|
@yukieiji i think the instance being |
Contributor
Author
|
@XtraCube don't work
[HarmonyPatch]
public static class InvalidOptionsPatches
{
[HarmonyTargetMethods]
public static IEnumerable<System.Reflection.MethodBase> TargetMethod()
{
var allType = AccessTools.AllTypes();
var optionType = allType
.Where(x => x.IsSubclassOf(typeof(IGameOptions)));
return optionType
.Select(x => AccessTools.Method(x, "AreInvalid"))
.Where(x => x != null);
}
[HarmonyPrefix]
public static bool IsOptionValid(Il2CppObjectBase __instance, [HarmonyArgument(0)] int maxExpectedPlayers)
{
var option = __instance.Cast<IGameOptions>();
return
option.MaxPlayers > maxExpectedPlayers ||
option.NumImpostors < 1 ||
option.NumImpostors + 1 > maxExpectedPlayers / 2 ||
option.GetInt(Int32OptionNames.KillDistance) is < 0 or > 2 ||
option.GetFloat(FloatOptionNames.PlayerSpeedMod) is <= 0f or > 3f;
}
}
|
|
Woah that does not look like a normal log, I'll see if I have time later today to look at it. |
|
Actually, dont use AccessTools.AllTypes(). Just use typeof(IGameOptions).Assembly.GetTypes() |
Contributor
Author
|
@XtraCube don't work
[HarmonyPatch]
public static class InvalidOptionsPatches
{
[HarmonyTargetMethods]
public static IEnumerable<System.Reflection.MethodBase> TargetMethod()
{
var allType = typeof(IGameOptions).Assembly.GetTypes();
var optionType = allType
.Where(x => x.IsSubclassOf(typeof(IGameOptions)));
return optionType
.Select(x => AccessTools.Method(x, "AreInvalid"))
.Where(x => x != null);
}
[HarmonyPrefix]
public static bool IsOptionValid(Il2CppObjectBase __instance, [HarmonyArgument(0)] int maxExpectedPlayers)
{
var option = __instance.Cast<IGameOptions>();
return
option.MaxPlayers > maxExpectedPlayers ||
option.NumImpostors < 1 ||
option.NumImpostors + 1 > maxExpectedPlayers / 2 ||
option.GetInt(Int32OptionNames.KillDistance) is < 0 or > 2 ||
option.GetFloat(FloatOptionNames.PlayerSpeedMod) is <= 0f or > 3f;
}
}
|
|
I figured out the issue, interfaces don't show up in inheritance. we have to use a different approach |
AlchlcDvl
approved these changes
Oct 14, 2025
Tommy-XL
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update mod to 2025.4.15(v16)+
Fixed unity object cast