fix _replaced_order_element_ids to avoid None returns#415
Merged
ernestoarbitrio merged 4 commits intomasterfrom Mar 2, 2026
Merged
fix _replaced_order_element_ids to avoid None returns#415ernestoarbitrio merged 4 commits intomasterfrom
ernestoarbitrio merged 4 commits intomasterfrom
Conversation
ernestoarbitrio
force-pushed
the
fix-3d-cube-with-odd-order
branch
from
51916b4 to
59d7266
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 4967 4967
=========================================
Hits 4967 4967 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ernestoarbitrio
commented
Mar 1, 2026
Comment on lines
+878
to
+882
| return [ | ||
| el | ||
| for _id in element_ids | ||
| if (el := self.translate_element_id(_id)) is not None | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
this is the fix :D
ernestoarbitrio
force-pushed
the
fix-3d-cube-with-odd-order
branch
from
c2836c1 to
d321700
Compare
ernestoarbitrio
requested review from
jjdelc and
tiagocoutinho
and removed request for
jjdelc and
tiagocoutinho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.