Skip to content

Refactor translation history functions to improve safety and clarity … #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JortVlaming merged 1 commit into from
Dec 16, 2025
Merged

Refactor translation history functions to improve safety and clarity … #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/mysql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,17 @@ export async function getTranslationFromHistory(
return null;
}

const row = rows[0]!; // Safe because we checked length

// Increment use count
await db.execute(
`UPDATE translation_history
SET use_count = use_count + 1, updated_at = CURRENT_TIMESTAMP
WHERE id = ?`,
[rows[0].id]
[row.id]
);

return rows[0] as TranslationHistoryEntry;
return row as TranslationHistoryEntry;
}

// Save translation to history
Expand All @@ -127,6 +129,7 @@ export async function saveTranslationToHistory(
);

if (existing.length > 0) {
const existingRow = existing[0]!; // Safe because we checked length
// Update existing entry
await db.execute(
`UPDATE translation_history
Expand All @@ -135,7 +138,7 @@ export async function saveTranslationToHistory(
use_count = use_count + 1,
updated_at = CURRENT_TIMESTAMP
WHERE id = ?`,
[translatedMessage, detectedLanguage, existing[0].id]
[translatedMessage, detectedLanguage, existingRow.id]
);
} else {
// Insert new entry
Expand Down
Loading