Skip to content

Have sensible defaults for the settings options #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crystalwarrior merged 1 commit into from
Dec 24, 2024
Merged

Have sensible defaults for the settings options #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ void Options::setColorLogEnabled(bool value)

bool Options::clearSoundsDropdownOnPlayEnabled() const
{
return config.value("stickysounds", true).toBool();
return config.value("stickysounds", false).toBool();
}

void Options::setClearSoundsDropdownOnPlayEnabled(bool value)
Expand All @@ -409,7 +409,7 @@ void Options::setClearSoundsDropdownOnPlayEnabled(bool value)

bool Options::clearEffectsDropdownOnPlayEnabled() const
{
return config.value("stickyeffects", true).toBool();
return config.value("stickyeffects", false).toBool();
}

void Options::setClearEffectsDropdownOnPlayEnabled(bool value)
Expand All @@ -419,7 +419,7 @@ void Options::setClearEffectsDropdownOnPlayEnabled(bool value)

bool Options::clearPreOnPlayEnabled() const
{
return config.value("stickypres", true).toBool();
return config.value("stickypres", false).toBool();
}

void Options::setClearPreOnPlayEnabled(bool value)
Expand Down Expand Up @@ -521,7 +521,7 @@ void Options::setAnimatedThemeEnabled(bool value)

QString Options::defaultScalingMode() const
{
return config.value("default_scaling", "fast").toString();
return config.value("default_scaling", "smooth").toString();
}

void Options::setDefaultScalingMode(QString value)
Expand Down Expand Up @@ -561,7 +561,7 @@ void Options::setPlaySelectedSFXOnIdle(bool value)

bool Options::evidenceDoubleClickEdit() const
{
return config.value("evidence_double_click", true).toBool();
return config.value("evidence_double_click", false).toBool();
}

void Options::setEvidenceDoubleClickEdit(bool value)
Expand Down
4 changes: 2 additions & 2 deletions src/widgets/aooptionsdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,8 +487,8 @@ void AOOptionsDialog::setupUI()

// Populate scaling dropdown. This is necessary as we need the user data
// embeeded into the entry.
ui_scaling_combobox->addItem(tr("Pixel"), "fast");
ui_scaling_combobox->addItem(tr("Smooth"), "smooth");
ui_scaling_combobox->addItem("pixel", "pixel");
ui_scaling_combobox->addItem("smooth", "smooth");

registerOption<QCheckBox, bool>("shake_cb", &Options::shakeEnabled,
&Options::setShakeEnabled);
Expand Down
Loading