-
Notifications
You must be signed in to change notification settings - Fork 32
Slides and Emote Specific Blips (2.11) #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Enables Slides and emote specific blips for 2.11 clients. Note that you'll still need a theme with the slide toggle added and slide appropriate backgrounds for it to work.
Crystalwarrior
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks OK, all that's left is to test it
|
Sorry been in the mines this year, I'll try to get this merged in January. If you can resolve merge conflicts that'll help but I can do that too if you're unable to. |
|
I assume it'll still work fine with the KFO-Client specific "video" additions but definitely worth checking that |
Crystalwarrior
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually can't merge this without proper validation because misaligning the packet indexes will actually break the client with video support in favor of AO2.11, we need a different approach sadly :/
| self.ArgType.STR, # 27 # blipname | ||
| self.ArgType.INT, # 28 # slide | ||
| self.ArgType.STR_OR_EMPTY, # 29 # video |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will actually break validation cuz Video HAS to be on position 27 :(
The validation monstrosity has caught up with us making this a difficult PR to merge
Enables Slides and emote specific blips for 2.11 (previously marked as 2.10.2) clients.
There's probably a better way than adding a new validation mess, but I do not have the energy to find out and I wish to never look at it again.
For slides, make sure to have a theme with the Slide toggle added
slide_enable = x, y, width, heightAs well as background(s) with the appropriate
courtimage and design.ini positions, documentation found at https://github.com/AttorneyOnline/docs/blob/master/docs/Content%20Creation/backgrounds.md#slide-ready-backgrounds-2102For Emote specific blips, you'll need to edit the char.ini with appropriate
[Options2]and[OptionsN]sections - documentation at https://github.com/AttorneyOnline/docs/blob/master/docs/Content%20Creation/characters/Overview.md#options2-etc-optional and https://github.com/AttorneyOnline/docs/blob/master/docs/Content%20Creation/characters/Overview.md#optionsn-optionalYes, it really did just take adding
"custom_blips",to tsuserver.py and I hated every second of trying to figure that out.