-
Notifications
You must be signed in to change notification settings - Fork 32
Add dependencies to pyproject.toml, fix testing, linting, scripts, instructions, etc. #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OmniTroid
wants to merge
19
commits into
Crystalwarrior:master
Choose a base branch
from
OmniTroid:pyproject
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Development setup section with uv sync, tox, and black commands. Simplify Server setup Install dependencies section to use uv. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace pip/flake8 with uv/ruff, update action versions, and add ruff to dependencies. Add lint instructions to README. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add ruff configuration to pyproject.toml - Fix wrong decorator @inventory.setter -> @latest_area.setter - Fix undefined target_id variable in area_access.py - Fix missing raise before ArgumentError in character.py - Replace bare except clauses with specific exception types - Auto-fix style issues (membership tests, comparisons, unused imports) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename tsuserver.py to kfoserver.py - Rename class TsuServer3 to KFOServer - Rename workflow to python-ci.yml and add test step - Update docker-compose service name - Replace tsuserver references with KFO-Server in docs and strings Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Copy config_sample to config if config folder doesn't exist - Remove hatchling build backend (not needed for server app) - Remove deprecated docker-compose version field Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Wrap websockets.serve() in async function to avoid get_running_loop() error - Update websocket handler to new single-argument API - Replace deprecated asyncio.get_event_loop() with asyncio.to_thread() - Remove deprecated loop= parameter from ensure_future calls Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements.txtwithpyproject.tomlusing uv for dependency management and setuptools as the build backendpython-ci.yml), switch from flake8 to ruff for linting, add pytest to CI pipelinetsuserver.py→kfoserver.py), and references throughout the codebasewebsockets.serve()in async function to fixget_running_loop()errorasyncio.get_event_loop()withasyncio.to_thread()loop=parameter fromensure_future()callsconfig_sampletoconfigon first startup if missing