Skip to content

FAC-95 FAC-96 refactor: curriculum service filter type safety and search deduplication#212

Merged
y4nder merged 1 commit intodevelopfrom
claude/implement-issues-210-211-52wy2
Mar 29, 2026
Merged

FAC-95 FAC-96 refactor: curriculum service filter type safety and search deduplication#212
y4nder merged 1 commit intodevelopfrom
claude/implement-issues-210-211-52wy2

Conversation

@y4nder
Copy link
Copy Markdown
Member

@y4nder y4nder commented Mar 29, 2026

Summary

Test plan

  • All 32 existing curriculum service tests pass
  • TypeScript build succeeds
  • Verify no runtime regression on list endpoints (departments, programs, courses) with and without search queries

Closes #210
Closes #211

https://claude.ai/code/session_01Y6eWhKjmgLfPJQMJa4VQQB

Replace `Record<string, unknown>` with typed `FilterQuery<Department>` and
`FilterQuery<Program>` intermediates, removing all `as FilterQuery<T>` casts
in ListPrograms and ListCourses (#210).

Extract duplicated $and/$or/$ilike search block into a shared
ApplySearchFilter helper used by all three list methods (#211).

Closes #210
Closes #211

https://claude.ai/code/session_01Y6eWhKjmgLfPJQMJa4VQQB
@y4nder y4nder changed the base branch from master to develop March 29, 2026 16:57
@y4nder y4nder self-assigned this Mar 29, 2026
@y4nder y4nder merged commit 52c5027 into develop Mar 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants