Add sponge platform #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cubxity
requested changes
Oct 8, 2022
Owner
Cubxity
left a comment
Cubxity
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Here is my rough review.
Important: please format the code properly.
api/src/main/kotlin/dev/cubxity/plugins/metrics/api/platform/PlatformType.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/dev/cubxity/plugins/metrics/api/platform/PlatformType.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Show resolved
Hide resolved
platforms/sponge/src/main/java/dev/cubxity/metrics/sponge/metric/events/EventsCollection.kt
Outdated
Show resolved
Hide resolved
platforms/sponge/src/main/java/dev/cubxity/metrics/sponge/metric/tick/TickReporter.kt
Show resolved
Hide resolved
Cubxity
requested changes
Oct 9, 2022
Owner
Cubxity
left a comment
Cubxity
left a comment
There was a problem hiding this comment.
The code is still not formatted properly.
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Show resolved
Hide resolved
This reverts commit 66d940c.
Author
|
@Cubxity anything else you want? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for sponge platform. I've only tested through influx dashboard. Needs testing in grafana. Aims to solve #21