Open
Conversation
Contributor
Author
|
It looks like some tests conflict with modification. |
hinto-janai
added
the
C-fix
Member
|
@YichiZhang0613 can I ask if you use AI and to what extent if you do? |
Contributor
Author
This PR was written by myself without AI. |
Member
Ok nice! do you use a tool to find these errors? if so what tool? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix problem mentioned in #497 .
Why
Check if permit is none as required to prevent potential improper behavior later.
Where
In p2p/p2p-core/src/handles.rs.
How
It will make fn build panic when permit is not set for HandleBuilder.