cuprated: broadcast newly added alt blocks to peers#577
Open
redsh4de wants to merge 1 commit intoCuprate:mainfrom
Open
cuprated: broadcast newly added alt blocks to peers#577redsh4de wants to merge 1 commit intoCuprate:mainfrom
redsh4de wants to merge 1 commit intoCuprate:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Broadcasts newly cached alt blocks to peers
Closes #524
Why
Prevent nodes from initiating a sync if they don't have a alt block and the alt chain wins
Where
cupratedblockchain/manager/handler.rs- splitCachedbool inAddAltBlockinto two variants -AlreadyCachedandNewlyCached(bytes), which points to the block blob. Used inhandle_incoming_blockto determine whether the block is newly added, and broadcasts the block if it isHow
Effectively the same pattern as for main blocks