Skip to content

Conversation

@atziatzios-ccycloud
Copy link

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new API endpoint /quotes/create for creating held rate quotes for currency conversions. The endpoint allows clients to request quotes with specific hold periods and conversion preferences.

Key Changes:

  • New POST /quotes/create endpoint with comprehensive parameter validation and error handling
  • Two new schema definitions: HeldRateQuote for successful responses and HeldRateQuoteError for error responses
  • Sample 200 response data demonstrating the quote creation response format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/reference.yaml Added Quotes tag, /quotes/create endpoint definition with request parameters, response schemas, and error specifications
data/local/swagger/responses/v2_quotes_create_POST_200.json Added sample successful response showing quote details including rates, amounts, and expiry information
Comments suppressed due to low confidence (1)

src/reference.yaml:1

  • The deposit_required field has inconsistent typing. In the schema definition it's specified as type: string (line 20550), but the example shows it as a boolean value false. This should be consistently defined as type: boolean in the schema.
swagger: '2.0'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +12341 to +12346
description: >-
Available and required only if conversion_date is not provided. Not currently supported for APAC currencies.<br>
Must be one of the following:<br>
- 'earliest' for earliest available conversion date. Make sure there is sufficient time to send funds to Currencycloud.<br>
- 'next_day' for next day available conversion date - T+1.<br>
- 'default' for conversion - T+1 for APAC, T+2 for everywhere else.<br>
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description uses HTML <br> tags for line breaks in a YAML string. This may not render correctly in all API documentation tools. Consider using YAML's literal block scalar syntax (|) or folded scalar syntax (>) for multi-line descriptions, or use proper YAML line continuation.

Suggested change
description: >-
Available and required only if conversion_date is not provided. Not currently supported for APAC currencies.<br>
Must be one of the following:<br>
- 'earliest' for earliest available conversion date. Make sure there is sufficient time to send funds to Currencycloud.<br>
- 'next_day' for next day available conversion date - T+1.<br>
- 'default' for conversion - T+1 for APAC, T+2 for everywhere else.<br>
description: |
Available and required only if conversion_date is not provided. Not currently supported for APAC currencies.
Must be one of the following:
- 'earliest' for earliest available conversion date. Make sure there is sufficient time to send funds to Currencycloud.
- 'next_day' for next day available conversion date - T+1.
- 'default' for conversion - T+1 for APAC, T+2 for everywhere else.

Copilot uses AI. Check for mistakes.
@atziatzios-ccycloud atziatzios-ccycloud marked this pull request as draft November 13, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants