Skip to content

Conversation

@lpi-tn
Copy link
Collaborator

@lpi-tn lpi-tn commented Aug 28, 2025

This pull request improves the handling of empty and single-page documents in the RefinedDocument class, ensuring that headers and footers are set to empty lists in these cases. It also adds corresponding tests to verify this behavior. Additionally, the package version is bumped to reflect these changes.

Improvements to document handling:

  • Updated the RefinedDocument class to set _processed_headers and _processed_footers to [[]] and log a warning when the provided content has only one page, ensuring consistent behavior for empty and single-page documents.

Testing enhancements:

  • Added test_empty_document and test_single_page_document to verify that headers and footers are empty lists and the body is handled correctly for empty and single-page documents.

Versioning:

  • Bumped the package version from 1.0.0 to 1.0.1 in pyproject.toml to reflect these updates.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the handling of edge cases in the RefinedDocument class by addressing empty and single-page documents, ensuring proper initialization of headers and footers for these scenarios.

  • Added special handling for single-page documents to set headers and footers to empty lists with proper logging
  • Enhanced test coverage with comprehensive tests for empty and single-page document scenarios
  • Incremented package version to reflect these improvements

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/refinedoc/refined_document.py Added condition to handle single-page documents by setting headers/footers to empty lists
tests/test_refined_document.py Added comprehensive tests for empty and single-page document edge cases
pyproject.toml Bumped version from 1.0.0 to 1.0.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@lpi-tn lpi-tn merged commit 028a1ac into main Aug 28, 2025
3 of 4 checks passed
@lpi-tn lpi-tn deleted the Fix/no-candidates branch August 28, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants