This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Changes for removing warnings during npm run build#44
Open
swaaaaaathii wants to merge 2 commits intomainfrom
Open
Changes for removing warnings during npm run build#44swaaaaaathii wants to merge 2 commits intomainfrom
swaaaaaathii wants to merge 2 commits intomainfrom
Conversation
macpd
reviewed
Jul 28, 2020
|
|
||
| function AdDetailsPage() { | ||
| const [adIdParam, setAdIdParam] = useQueryParam('ad_id', StringParam); | ||
| const adIdParam = useQueryParam('ad_id', StringParam); |
Contributor
There was a problem hiding this comment.
I think this is why /cluster is broken. adIdParam is not a string now. it's an array of string and function. https://reactjs.org/docs/hooks-state.html#tip-what-do-square-brackets-mean
Contributor
There was a problem hiding this comment.
for now, leave this line as is, and disable lint on it with a comment like https://github.com/OnlinePoliticalTransparency/ad_screener/blob/master/src/AdScreenerTool.js#L299
Contributor
Author
There was a problem hiding this comment.
Got it! Will do.
Comment on lines
+19
to
+20
| console.log(startingDate); | ||
| console.log(endingDate); |
Contributor
Author
There was a problem hiding this comment.
I had added them to remove an unused variable warning. I'll disable lint instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.