replace camera layering with cubemap skybox render texture#10
Open
fauxnik wants to merge 13 commits intoCybexGS:masterfrom
Open
replace camera layering with cubemap skybox render texture#10fauxnik wants to merge 13 commits intoCybexGS:masterfrom
fauxnik wants to merge 13 commits intoCybexGS:masterfrom
Conversation
TODO: * fix clouds & stars * add skybox/cubemap material to main asset bundle
at least for clouds stars are still missing
adds layered cubemap material/shader without the need for extra zwrite_test asset bundle
Collaborator
Author
|
I think this may be as far as I'm gonna be able to take this branch. I haven't been able to figure out the HDR issue with the cubemap texture, but perhaps it good enough? Let me know if you have any outstanding concerns that would block merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible for other mods to add their own camera without having to create special case(s) for when ProSky mod is also installed/active.
Example of how other mods that add cameras benefit from this: fauxnik/dv-smooth-camera@16f430e
@CybexGS I need your help with this, unless you think it's fine to have a separate resource bundle for this: