Conversation
|
As we don't need this else branch, we can initialize the vector |
xuanhien070594
left a comment
There was a problem hiding this comment.
@xuanhien070594 reviewed 9 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Meow404).
Meow404
left a comment
There was a problem hiding this comment.
@Meow404 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @xuanhien070594).
multibody/lcs_factory.cc line 123 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
As we don't need this else branch, we can initialize the vector
planar_normal_direction_per_contact_with all default values{ }, then assign new value whenn_friction_directions_per_contact_[i] == 1. In addition, can we use single for loop to reduce code duplication?
Done.
xuanhien070594
left a comment
There was a problem hiding this comment.
@xuanhien070594 reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Meow404).
LCOV of commit
|
This change is