Update LcmDrivenLoop to add a message queue size parameter#366
Open
Brian-Acosta wants to merge 4 commits intomainfrom
Open
Update LcmDrivenLoop to add a message queue size parameter#366Brian-Acosta wants to merge 4 commits intomainfrom
Brian-Acosta wants to merge 4 commits intomainfrom
Conversation
mposa
requested changes
Oct 4, 2024
Contributor
mposa
left a comment
mposa
left a comment
There was a problem hiding this comment.
I added a bit of documentation, and just have one additional comment/question.
Remove unused wait_for_message
mposa
reviewed
Oct 4, 2024
Contributor
mposa
left a comment
mposa
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sharanyashastry)
sharanyashastry
added a commit
that referenced
this pull request
Oct 7, 2024
… stored the first message it received after being cleared and never replaced them with newer messages. This fix makes the buffer size bigger and ensures that the latest message is picked up before clearing the buffer. RobotLocomotion/drake#15234 details this issue and the PR on main #366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses RobotLocomotion/drake#15234 by adding the ability to set the queue size of LcmDrivenLoop's internal subscribers, and handling the lcm subscription until the queue is empty (up to date) on each loop.
This change is