Stabilize widget settings restore and async loading behavior#14
Merged
d-chambers merged 6 commits intomainfrom Apr 7, 2026
Merged
Stabilize widget settings restore and async loading behavior#14d-chambers merged 6 commits intomainfrom
d-chambers merged 6 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a shared settings-to-controls restore pattern in the widget base classes and applies it to the
widgets that were drifting most often between persisted settings, visible controls, and runtime execution state. It
also tightens async loading indicators and hardens several
SpoolandWaterfallrestore/error paths.What changed
Shared widget lifecycle
ZugWidget:_apply_settings_to_controls()_sync_settings_from_controls()_rebind_dynamic_controls()PatchDimWidgetto rebind dim-dependent controls through the shared dynamic-control hook.Spool
Spoolto use explicit hydrate/sync/rebind phases.chunk_enabledfrom remembered chunk parameter values.widget empty.
file_path_edit.Coords / Select / Waterfall
Coordssync intentionally narrow so invalid or not-yet-available saved values are not erased during patchrebinding.
Waterfallrestore/control sync to use the shared hook pattern.Waterfall.reset_on_newbehavior so coordinate changes reset the view, while ordinary patch replacementscan still preserve view range when appropriate.
Why
Several widgets had the same failure mode:
This PR establishes a consistent restore contract in the base classes and applies it first to the highest-risk
widgets so saved workflows, live controls, and execution behavior stay aligned.