Skip to content
This repository was archived by the owner on Jan 8, 2025. It is now read-only.

Remove unused ManuScript code that does not work any more#124

Open
th-we wants to merge 3 commits intoDDMAL:developfrom
notengrafik:remove-unused-code
Open

Remove unused ManuScript code that does not work any more#124
th-we wants to merge 3 commits intoDDMAL:developfrom
notengrafik:remove-unused-code

Conversation

@th-we
Copy link

@th-we th-we commented May 16, 2021

This unused code won't work any more because the surrounding code has evolved away from it. Specifically, MEIFlattened is no longer a SparseArray and can not be used in the way these function use it.

@th-we
Copy link
Author

th-we commented Aug 23, 2021

@ahankinson Can we merge this? To sum up the changes:

  • getPositionInDocument() and lookBack() were removed. They do not work any more because they assume the global MEIFlattened is a SparseArray, but it's not a Dictionary. They are not used anyway in either libmei.plg or sibmei.
  • XML parser is "parked" in a separate Python variable, documenting the state of the code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant