simplify compound commands and improve error handling in compounds and open+getattr #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no functional change Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
…) returns some other error than ENOSYS. The returned error got overwritten. Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
hbirth
changed the title
Collaborator
|
Maybe we should update with the version for upstream? |
Collaborator
Author
That is actually a good idea |
hbirth
changed the title
hbirth
force-pushed
the
redfs-ubuntu-noble-6.8.0-58.60
branch
2 times, most recently
from
b74783d to
be508b6
Compare
Collaborator
Author
|
@bsbernd could you take another look? ... it is actually the fixes to enable compounds and the update to the version from upstream |
bsbernd
reviewed
Jan 12, 2026
bsbernd
reviewed
Jan 12, 2026
bsbernd
reviewed
Jan 12, 2026
bsbernd
reviewed
Jan 12, 2026
bsbernd
reviewed
Jan 12, 2026
bsbernd
reviewed
Jan 12, 2026
bsbernd
reviewed
Jan 12, 2026
Simplify fuse_compound_req to hold only the pointers to the added fuse args and the request housekeeping. Simplify open+getattr call by using helper functions to fill out the fuse request parameters Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
hbirth
force-pushed
the
redfs-ubuntu-noble-6.8.0-58.60
branch
from
be508b6 to
b97043e
Compare
bsbernd
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.