replace random.random with np.random.choice in selRoulette#689
Open
Mach-2 wants to merge 3 commits intoDEAP:masterfrom
Open
replace random.random with np.random.choice in selRoulette#689Mach-2 wants to merge 3 commits intoDEAP:masterfrom
Mach-2 wants to merge 3 commits intoDEAP:masterfrom
Conversation
Member
|
Could this be done with the new random.choices? |
Author
|
Yes, random.choices looks like it does the same thing. This shaved off a bit of runtime again, too! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that selRoulette was causing a major bottleneck when I tried to scale up to larger populations. This update uses the
np.random.choicefunction in place ofrandom.random, which removes the need to sort the input list of individuals and the nested for loops.