algorithms: Accept optional logbook instance#770
Open
leandrolanzieri wants to merge 1 commit intoDEAP:masterfrom
Open
algorithms: Accept optional logbook instance#770leandrolanzieri wants to merge 1 commit intoDEAP:masterfrom
leandrolanzieri wants to merge 1 commit intoDEAP:masterfrom
Conversation
Member
|
I like your PR, the only thing that I'm wondering is the signature change for those using only positional arguments. |
Author
Right. I'll move the |
d23d330 to
7e00e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In many cases it may be useful to monitor the evolution process as it happens. As the complete algorithms provide no callback while running, a reasonable entry point is the logbook. The user can create a custom
Logbookclass that processes statistics as they are recorded (e.g., writing to a tensorboard writer).This PR suggests that algorithms accept an optional
logbookparameter that the user can instantiate. When not provided, the behaviour remains the same.