Demotes H1 in markdown if required#1197
Merged
jbarnsley10 merged 4 commits intomainfrom Nov 24, 2025
Merged
Conversation
12 tasks
|
mokhld
approved these changes
Nov 14, 2025
alexluckett
requested changes
Nov 17, 2025
Contributor
alexluckett
left a comment
alexluckett
left a comment
There was a problem hiding this comment.
As discussed - agreed to move this towards a contextual rendering where the entire hierarchy is demoted.
alexluckett
reviewed
Nov 20, 2025
| <div class="govuk-form-group"> | ||
| <div class="{{ model.declaration.classes }}"> | ||
| {{ model.declaration.text | markdown | safe }} | ||
| {{ model.declaration.text | markdown({ startingHeaderLevel: 2 }) | safe }} |
Contributor
There was a problem hiding this comment.
do we need this for the guidance/markdown component too?
Contributor
There was a problem hiding this comment.
Nailed it, otherwise 👌
Contributor
Author
There was a problem hiding this comment.
Good point. It's been a while so I've forgotten what was going on. I'll check 😀
Contributor
Author
There was a problem hiding this comment.
Guidance/markdown is covered in the changes to file markdown.js in this PR. I tested the preview and it's all fine.
alexluckett
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket DF-480
Demotes any H1-6 from the starting level supplied. For example, if the starting level is 2, any H1's will become H2's, H2's will become H3's etc. If the starting level is 3, any H1's will become H3's and so on.
This is to ensure there is only one H1 on the page (either the page/component title, or an H1 from within the markdown), and that the rest of the page's heading flow down in order.
In tandem with forms-engine-plugin PR DEFRA/forms-engine-plugin#246