feat/df-1006: dlq modify rework#1408
Merged
jbarnsley10 merged 8 commits intomainfrom Apr 30, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
jbarnsley10
changed the title
🧪 Acceptance Test Results❌ Some acceptance tests failed |
alexluckett
reviewed
Apr 29, 2026
Comment on lines
+57
to
+69
| const queryParams = [] | ||
| if (options?.visibilityTimeout) { | ||
| queryParams.push(`visibilityTimeout=${options.visibilityTimeout}`) | ||
| } | ||
| if (options?.waitTimeSeconds) { | ||
| queryParams.push(`waitTimeSeconds=${options.waitTimeSeconds}`) | ||
| } | ||
| const queryParamStr = queryParams.length ? `?${queryParams.join('&')}` : '' | ||
|
|
||
| const requestUrl = new URL( | ||
| `./admin/deadletter${qualifier}/view${queryParamStr}`, | ||
| endpoint | ||
| ) |
Contributor
There was a problem hiding this comment.
use the built-in search params builder instead
const requestUrl = new URL(
`./admin/deadletter${qualifier}/view${queryParamStr}`,
endpoint
)
if (options?.visibilityTimeout) {
url.searchParams.set("visibilityTimeout", options.visibilityTimeout)
}
| <a class="govuk-link govuk-link--no-visited-state govuk-!-margin-right-9" href="audit-api/modify/message-id">Modify and resubmit</a> | ||
| <form method="post" action="audit-api/modify-redirect/message-id" class="app-inline-block-form govuk-!-margin-right-9"> | ||
| <input type="hidden" name="action" value="modify" /> | ||
| <input type="hidden" name="messageJsonText" value="{"MessageId":"message-id","Body":{"field1":"value1"}}" /> |
Contributor
There was a problem hiding this comment.
bit confused by this, why would we hardcode a value?
{
"MessageId": "message-id",
"Body": {
"field1": "value1"
}
}
Contributor
Author
There was a problem hiding this comment.
It's a snapshot for a unit test where that message content is setup in the unit test.
The actual NJK file contains dynamic content:
<input type="hidden" name="messageJsonText" value="{{ message.json | dump }}" />
Contributor
There was a problem hiding this comment.
oh so it is !! my bad, i saw this as the actual nunjucks view.
|
alexluckett
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'modify and resubmit' payload handled within form posts, so doesn't have to re-read message from queue again
In tandem with DEFRA/forms-notify-listener#174