Skip to content

Gracefully handle file upload persistence errors by clearing state #1230

Gracefully handle file upload persistence errors by clearing state

Gracefully handle file upload persistence errors by clearing state #1230

Triggered via pull request December 11, 2025 10:35
Status Failure
Total duration 3m 2s
Artifacts 3

check-pull-request.yml

on: pull_request
Matrix: build
Matrix: tasks
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

18 errors and 1 warning
EditorConfig (Node 24)
Process completed with exit code 1.
EditorConfig (Node 22)
Process completed with exit code 1.
EditorConfig (Node 23)
Process completed with exit code 1.
ESLint (Node 22)
Process completed with exit code 1.
ESLint (Node 24)
Process completed with exit code 1.
ESLint (Node 23)
Process completed with exit code 1.
Unit tests (Node 24)
Process completed with exit code 1.
Nunjucks context › Crumb › should generate crumb when state exists: src/server/plugins/nunjucks/context.js#L50
TypeError: Cannot read properties of undefined (reading 'flash') at flash (src/server/plugins/nunjucks/context.js:50:36) at Object.<anonymous> (src/server/plugins/nunjucks/context.test.js:128:38)
Nunjucks context › Crumb › should handle malformed requests with missing state: src/server/plugins/nunjucks/context.js#L50
TypeError: Cannot read properties of undefined (reading 'flash') at flash (src/server/plugins/nunjucks/context.js:50:36) at Object.<anonymous> (src/server/plugins/nunjucks/context.test.js:95:38)
Submission journey test › POST /file-upload-component returns 303: test/form/persist-files.test.js#L209
expect(jest.fn()).toHaveBeenCalledWith(...expected) - Expected + Received [{"fileId": "a9e7470b-86a5-4826-a908-360a36aac71d", "initiatedRetrievalKey": "foo.bar@defra.gov.uk"}, {"fileId": "a9e7470b-86a5-4826-a908-360a36aac72a", "initiatedRetrievalKey": "foo.bar@defra.gov.uk"}], - "enrique.chase@defra.gov.uk", + "defraforms@defra.gov.uk", Number of calls: 1 at Object.toHaveBeenCalledWith (test/form/persist-files.test.js:209:26)
Unit tests (Node 22)
Process completed with exit code 1.
Nunjucks context › Crumb › should generate crumb when state exists: src/server/plugins/nunjucks/context.js#L50
TypeError: Cannot read properties of undefined (reading 'flash') at flash (src/server/plugins/nunjucks/context.js:50:36) at Object.<anonymous> (src/server/plugins/nunjucks/context.test.js:128:38)
Nunjucks context › Crumb › should handle malformed requests with missing state: src/server/plugins/nunjucks/context.js#L50
TypeError: Cannot read properties of undefined (reading 'flash') at flash (src/server/plugins/nunjucks/context.js:50:36) at Object.<anonymous> (src/server/plugins/nunjucks/context.test.js:95:38)
Submission journey test › POST /file-upload-component returns 303: test/form/persist-files.test.js#L209
expect(jest.fn()).toHaveBeenCalledWith(...expected) - Expected + Received [{"fileId": "a9e7470b-86a5-4826-a908-360a36aac71d", "initiatedRetrievalKey": "foo.bar@defra.gov.uk"}, {"fileId": "a9e7470b-86a5-4826-a908-360a36aac72a", "initiatedRetrievalKey": "foo.bar@defra.gov.uk"}], - "enrique.chase@defra.gov.uk", + "defraforms@defra.gov.uk", Number of calls: 1 at Object.toHaveBeenCalledWith (test/form/persist-files.test.js:209:26)
Unit tests (Node 23)
Process completed with exit code 1.
Nunjucks context › Crumb › should generate crumb when state exists: src/server/plugins/nunjucks/context.js#L50
TypeError: Cannot read properties of undefined (reading 'flash') at flash (src/server/plugins/nunjucks/context.js:50:36) at Object.<anonymous> (src/server/plugins/nunjucks/context.test.js:128:38)
Nunjucks context › Crumb › should handle malformed requests with missing state: src/server/plugins/nunjucks/context.js#L50
TypeError: Cannot read properties of undefined (reading 'flash') at flash (src/server/plugins/nunjucks/context.js:50:36) at Object.<anonymous> (src/server/plugins/nunjucks/context.test.js:95:38)
Submission journey test › POST /file-upload-component returns 303: test/form/persist-files.test.js#L209
expect(jest.fn()).toHaveBeenCalledWith(...expected) - Expected + Received [{"fileId": "a9e7470b-86a5-4826-a908-360a36aac71d", "initiatedRetrievalKey": "foo.bar@defra.gov.uk"}, {"fileId": "a9e7470b-86a5-4826-a908-360a36aac72a", "initiatedRetrievalKey": "foo.bar@defra.gov.uk"}], - "enrique.chase@defra.gov.uk", + "defraforms@defra.gov.uk", Number of calls: 1 at Object.toHaveBeenCalledWith (test/form/persist-files.test.js:209:26)
Vulnerability warning
This version of the SonarQube Scanner GitHub Action is no longer supported and contains a security vulnerability. Please update your workflow to use sonarsource/sonarqube-scan-action@v6 for the latest security patches and features. For more information visit https://community.sonarsource.com/gha-v6-update

Artifacts

Produced during runtime
Name Size Digest
Unit tests coverage (Node 22) Expired
696 KB
sha256:6702c155dbbfe45c130b52b66ca099b81531cbbca1ea458218ffe8312a1a58ed
Unit tests coverage (Node 23) Expired
696 KB
sha256:71d7fe4bef50f8eff841681711f8f273040fc4dcd1ee900340fccdac87b0d2d6
Unit tests coverage (Node 24) Expired
696 KB
sha256:aec76341e46a5a7e85207dd2e92c979480687ca322cb6ff80a2a76c91044a9b3