Gracefully handle file upload persistence errors by clearing state

[alexluckett]

Proposed change

Files may disappear if they've expired (unexpected bugs with retrieveal keys, file expiry on S3, etc). Currently form submissions can go through with invalid file upload state as we don't re-check it before submission.

This PR:

• clears state for problematic file upload questions (an exceptional scenario), rather than breaking the entire form submission.
• moves file submission logic into a new onSubmit function within the component and removes special handling within SummaryPageController
• removes the legacy definition.outputEmail feature, in favour of metadata.notificationEmail

Jira ticket: https://eaflood.atlassian.net/browse/DF-719

Type of change

• Bug fix
• New feature
• Breaking change
• Misc. (documentation, build updates, etc)

Checklist

• You have executed this code locally and it performs as expected.
• You have added tests to verify your code works.
• You have added code comments and JSDoc, where appropriate.
• There is no commented-out code.
• You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
• The tests are passing (npm run test).
• The linting checks are passing (npm run lint).
• The code has been formatted (npm run format).

[alexluckett]

This is one of the key changes

this used to be: definition.outputEmail and was swapped to metadata.notificationEmail.

[davidjamesstone]

Is the fallback needed here?
We would'nt be inside this function if there was no notificationEmail given this line

[jbarnsley10]

Great work. My only question would be 'is it a sensible user experience where multiple files from say multiple upload pages have disappeared?' i.e. does it handle one error at a time, or all at once etc
Also there's a minor Sonar issue on a negated condition.
Approving

[davidjamesstone]

Awesome - love it

[Scullyon]

Looks really good, just a minor comment in one of the files and also wondered the same thing as Jez.

[Scullyon]

Should this be in here or would the component itself be a better location for its own state keys? This method could then obtain the data from the component.

[alexluckett]

Really good idea, that would be a better place to do it. I'll leave this as a follow-up though as this has been hanging around a bit over the holidays.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud