Skip to content

Fix/df 380 resolve circular imports#178

Merged
whitewaterdesign merged 4 commits intomainfrom
fix/DF-380--resolve-circular-imports
Aug 28, 2025
Merged

Fix/df 380 resolve circular imports#178
whitewaterdesign merged 4 commits intomainfrom
fix/DF-380--resolve-circular-imports

Conversation

@whitewaterdesign
Copy link
Copy Markdown
Contributor

@whitewaterdesign whitewaterdesign commented Aug 27, 2025

Proposed change

When importing the forms-engine-plugin there are numerous circular imports which are causing errors for example on enum imports. In order to take a first step at resolving this, there is now separation between helpers.ts methods which rely on an import of all the components (these have been moved to factory.ts and those which have no other imports which could be circular. The same change has been actioned in page controllers. There is for sure more that needs to be done in future, but this will take a first step at resolving.

Jira ticket:

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@whitewaterdesign whitewaterdesign requested a review from a team August 27, 2025 18:32
@sonarqubecloud
Copy link
Copy Markdown

@whitewaterdesign whitewaterdesign merged commit eb88942 into main Aug 28, 2025
9 checks passed
@whitewaterdesign whitewaterdesign deleted the fix/DF-380--resolve-circular-imports branch August 28, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants