Fix/df 380 resolve circular imports#178
Merged
whitewaterdesign merged 4 commits intomainfrom Aug 28, 2025
Merged
Conversation
added 2 commits
August 27, 2025 18:15
…onent circular imports
… circular imports
alexluckett
approved these changes
Aug 28, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
When importing the
forms-engine-pluginthere are numerous circular imports which are causing errors for example on enum imports. In order to take a first step at resolving this, there is now separation betweenhelpers.tsmethods which rely on an import of all the components (these have been moved tofactory.tsand those which have no other imports which could be circular. The same change has been actioned in page controllers. There is for sure more that needs to be done in future, but this will take a first step at resolving.Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).