Feat/df 370 save progress#182
Merged
davidjamesstone merged 7 commits intomainfrom Sep 8, 2025
Merged
Conversation
* Export plugin schema * Update save and exit options * Update save and exit configuration options * Update cacheService to remove old save and exit implementation * Update save and exit tests * Update save and exit docs * Remove old save and return exit page * Add FormResponseToolkit for convenience * Refactor to use new FormResponseToolkit * Add and export "AnyRequest" type * Add, export and use "AnyFormRequest" type * Add docs on restoring a saved session
davidjamesstone
force-pushed
the
feat/DF-370-save-progress
branch
from
55accfe to
f426d14
Compare
| const baseKey = this.generateKey | ||
| ? this.generateKey(request) | ||
| : this.defaultKeyGenerator(request) | ||
| Key(request: AnyRequest, additionalIdentifier?: ADDITIONAL_IDENTIFIER) { |
Contributor
There was a problem hiding this comment.
just wondering why this is pascal case?
whitewaterdesign
approved these changes
Sep 8, 2025
Contributor
whitewaterdesign
left a comment
whitewaterdesign
left a comment
There was a problem hiding this comment.
Looks good to me, mostly just a name refactor from what I can see
alexluckett
approved these changes
Sep 8, 2025
* Renamed saveAndReturn to saveAndExit * Further rename to saveAndExit * Accept new class for cache service input * Accept a CacheService instance instead of a cache name * Export CacheService * use kebab case to align cache service with file form service * Add trailing newline to satisfy editorconfig * Fix state leakage between tests --------- Co-authored-by: Jez Barnsley <jbarnsley.github@gmail.com>
Contributor
|
@jbarnsley10 before you merge this, we'll mark it as a major release. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Renames 'Save and Return' to 'Save and Exit'
Jira ticket:
DF-370
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).